From 18c71b259e50d219dd5b8532060c89c6e90429bf Mon Sep 17 00:00:00 2001
From: Connor Yoh <connor@stirlingpdf.com>
Date: Fri, 12 Sep 2025 16:49:55 +0100
Subject: [PATCH] Remove redudant constants

---
 .../components/tools/split/SplitSettings.tsx  |  8 +++---
 frontend/src/constants/splitConstants.ts      | 28 -------------------
 .../hooks/tools/split/useSplitOperation.ts    |  2 +-
 .../hooks/tools/split/useSplitParameters.ts   |  2 +-
 4 files changed, 6 insertions(+), 34 deletions(-)

diff --git a/frontend/src/components/tools/split/SplitSettings.tsx b/frontend/src/components/tools/split/SplitSettings.tsx
index 5b447aa18..687c2733c 100644
--- a/frontend/src/components/tools/split/SplitSettings.tsx
+++ b/frontend/src/components/tools/split/SplitSettings.tsx
@@ -1,6 +1,6 @@
 import { Stack, TextInput, Select, Checkbox } from '@mantine/core';
 import { useTranslation } from 'react-i18next';
-import { isSplitMethod, SPLIT_METHODS, METHOD_TO_SPLIT_TYPE, SPLIT_TYPES } from '../../../constants/splitConstants';
+import { isSplitMethod, SPLIT_METHODS } from '../../../constants/splitConstants';
 import { SplitParameters } from '../../../hooks/tools/split/useSplitParameters';
 
 export interface SplitSettingsProps {
@@ -59,7 +59,7 @@ const SplitSettings = ({
 
   const renderSplitValueForm = () => {
     let label, placeholder;
-    
+
     switch (parameters.method) {
       case SPLIT_METHODS.BY_SIZE:
         label = t("split.value.fileSize.label", "File Size");
@@ -135,8 +135,8 @@ const SplitSettings = ({
       {/* Parameter Form */}
       {parameters.method === SPLIT_METHODS.BY_PAGES && renderByPagesForm()}
       {parameters.method === SPLIT_METHODS.BY_SECTIONS && renderBySectionsForm()}
-      {(parameters.method === SPLIT_METHODS.BY_SIZE || 
-        parameters.method === SPLIT_METHODS.BY_PAGE_COUNT || 
+      {(parameters.method === SPLIT_METHODS.BY_SIZE ||
+        parameters.method === SPLIT_METHODS.BY_PAGE_COUNT ||
         parameters.method === SPLIT_METHODS.BY_DOC_COUNT) && renderSplitValueForm()}
       {parameters.method === SPLIT_METHODS.BY_CHAPTERS && renderByChaptersForm()}
     </Stack>
diff --git a/frontend/src/constants/splitConstants.ts b/frontend/src/constants/splitConstants.ts
index 55230b068..896e4bc44 100644
--- a/frontend/src/constants/splitConstants.ts
+++ b/frontend/src/constants/splitConstants.ts
@@ -7,19 +7,6 @@ export const SPLIT_METHODS = {
   BY_CHAPTERS: 'byChapters'
 } as const;
 
-// Legacy constants for backward compatibility
-export const SPLIT_MODES = {
-  BY_PAGES: 'byPages',
-  BY_SECTIONS: 'bySections',
-  BY_SIZE_OR_COUNT: 'bySizeOrCount',
-  BY_CHAPTERS: 'byChapters'
-} as const;
-
-export const SPLIT_TYPES = {
-  SIZE: 'size',
-  PAGES: 'pages',
-  DOCS: 'docs'
-} as const;
 
 export const ENDPOINTS = {
   [SPLIT_METHODS.BY_PAGES]: 'split-pages',
@@ -30,24 +17,9 @@ export const ENDPOINTS = {
   [SPLIT_METHODS.BY_CHAPTERS]: 'split-pdf-by-chapters'
 } as const;
 
-export const METHOD_TO_SPLIT_TYPE = {
-  [SPLIT_METHODS.BY_SIZE]: SPLIT_TYPES.SIZE,
-  [SPLIT_METHODS.BY_PAGE_COUNT]: SPLIT_TYPES.PAGES,
-  [SPLIT_METHODS.BY_DOC_COUNT]: SPLIT_TYPES.DOCS
-} as const;
-
 export type SplitMethod = typeof SPLIT_METHODS[keyof typeof SPLIT_METHODS];
-export type SplitMode = typeof SPLIT_MODES[keyof typeof SPLIT_MODES];
-export type SplitType = typeof SPLIT_TYPES[keyof typeof SPLIT_TYPES];
-
 export const isSplitMethod = (value: string | null): value is SplitMethod => {
   return Object.values(SPLIT_METHODS).includes(value as SplitMethod);
 }
 
-export const isSplitMode = (value: string | null): value is SplitMode => {
-  return Object.values(SPLIT_MODES).includes(value as SplitMode);
-}
 
-export const isSplitType = (value: string | null): value is SplitType => {
-  return Object.values(SPLIT_TYPES).includes(value as SplitType);
-}
diff --git a/frontend/src/hooks/tools/split/useSplitOperation.ts b/frontend/src/hooks/tools/split/useSplitOperation.ts
index 97e439f48..b7ad93af0 100644
--- a/frontend/src/hooks/tools/split/useSplitOperation.ts
+++ b/frontend/src/hooks/tools/split/useSplitOperation.ts
@@ -3,7 +3,7 @@ import { useTranslation } from 'react-i18next';
 import { ToolType, useToolOperation, ToolOperationConfig } from '../shared/useToolOperation';
 import { createStandardErrorHandler } from '../../../utils/toolErrorHandler';
 import { SplitParameters, defaultParameters } from './useSplitParameters';
-import { SPLIT_METHODS, METHOD_TO_SPLIT_TYPE } from '../../../constants/splitConstants';
+import { SPLIT_METHODS } from '../../../constants/splitConstants';
 import { useToolResources } from '../shared/useToolResources';
 
 // Static functions that can be used by both the hook and automation executor
diff --git a/frontend/src/hooks/tools/split/useSplitParameters.ts b/frontend/src/hooks/tools/split/useSplitParameters.ts
index 9722e718d..09b1ff1c9 100644
--- a/frontend/src/hooks/tools/split/useSplitParameters.ts
+++ b/frontend/src/hooks/tools/split/useSplitParameters.ts
@@ -1,4 +1,4 @@
-import { SPLIT_METHODS, SPLIT_MODES, SPLIT_TYPES, ENDPOINTS, METHOD_TO_SPLIT_TYPE, type SplitMethod, SplitMode, SplitType } from '../../../constants/splitConstants';
+import { SPLIT_METHODS, ENDPOINTS, type SplitMethod } from '../../../constants/splitConstants';
 import { BaseParameters } from '../../../types/parameters';
 import { useBaseParameters, BaseParametersHook } from '../shared/useBaseParameters';