diff --git a/proprietary/src/main/java/stirling/software/proprietary/security/InitialSecuritySetup.java b/proprietary/src/main/java/stirling/software/proprietary/security/InitialSecuritySetup.java index d36d891bc..23f1100e6 100644 --- a/proprietary/src/main/java/stirling/software/proprietary/security/InitialSecuritySetup.java +++ b/proprietary/src/main/java/stirling/software/proprietary/security/InitialSecuritySetup.java @@ -2,6 +2,7 @@ package stirling.software.proprietary.security; import java.sql.SQLException; import java.util.List; +import java.util.Optional; import java.util.UUID; import org.springframework.stereotype.Component; @@ -53,10 +54,15 @@ public class InitialSecuritySetup { private void assignUsersToDefaultTeamIfMissing() { Team defaultTeam = teamService.getOrCreateDefaultTeam(); + Team internalTeam = teamService.getOrCreateInternalTeam(); List usersWithoutTeam = userService.getUsersWithoutTeam(); for (User user : usersWithoutTeam) { - user.setTeam(defaultTeam); + if (user.getUsername().equalsIgnoreCase(Role.INTERNAL_API_USER.getRoleId())) { + user.setTeam(internalTeam); + } else { + user.setTeam(defaultTeam); + } } userService.saveAll(usersWithoutTeam); // batch save @@ -108,6 +114,20 @@ public class InitialSecuritySetup { false); userService.addApiKeyToUser(Role.INTERNAL_API_USER.getRoleId()); log.info("Internal API user created: {}", Role.INTERNAL_API_USER.getRoleId()); + } else { + Optional internalApiUserOpt = + userService.findByUsernameIgnoreCase(Role.INTERNAL_API_USER.getRoleId()); + if (internalApiUserOpt.isPresent()) { + User internalApiUser = internalApiUserOpt.get(); + // move to team internal API user + if (!internalApiUser.getTeam().getName().equals(TeamService.INTERNAL_TEAM_NAME)) { + log.info( + "Moving internal API user to team: {}", TeamService.INTERNAL_TEAM_NAME); + Team internalTeam = teamService.getOrCreateInternalTeam(); + + userService.changeUserTeam(internalApiUser, internalTeam); + } + } } userService.syncCustomApiUser(applicationProperties.getSecurity().getCustomGlobalAPIKey()); } diff --git a/proprietary/src/main/java/stirling/software/proprietary/security/model/User.java b/proprietary/src/main/java/stirling/software/proprietary/security/model/User.java index c2461269a..d3e232f61 100644 --- a/proprietary/src/main/java/stirling/software/proprietary/security/model/User.java +++ b/proprietary/src/main/java/stirling/software/proprietary/security/model/User.java @@ -58,7 +58,7 @@ public class User implements Serializable { @OneToMany(fetch = FetchType.EAGER, cascade = CascadeType.ALL, mappedBy = "user") private Set authorities = new HashSet<>(); - @ManyToOne(fetch = FetchType.LAZY) + @ManyToOne(fetch = FetchType.EAGER) @JoinColumn(name = "team_id") private Team team; diff --git a/proprietary/src/main/java/stirling/software/proprietary/security/service/UserService.java b/proprietary/src/main/java/stirling/software/proprietary/security/service/UserService.java index 9d1ae6fc8..50c8027f6 100644 --- a/proprietary/src/main/java/stirling/software/proprietary/security/service/UserService.java +++ b/proprietary/src/main/java/stirling/software/proprietary/security/service/UserService.java @@ -371,6 +371,16 @@ public class UserService implements UserServiceInterface { databaseService.exportDatabase(); } + public void changeUserTeam(User user, Team team) + throws SQLException, UnsupportedProviderException { + if (team == null) { + team = getDefaultTeam(); + } + user.setTeam(team); + userRepository.save(user); + databaseService.exportDatabase(); + } + public boolean isPasswordCorrect(User user, String currentPassword) { return passwordEncoder.matches(currentPassword, user.getPassword()); } diff --git a/stirling-pdf/src/main/resources/static/js/pages/edit-table-of-contents.js b/stirling-pdf/src/main/resources/static/js/pages/edit-table-of-contents.js index 5bd0001e6..de7fe30db 100644 --- a/stirling-pdf/src/main/resources/static/js/pages/edit-table-of-contents.js +++ b/stirling-pdf/src/main/resources/static/js/pages/edit-table-of-contents.js @@ -435,14 +435,14 @@ document.addEventListener('DOMContentLoaded', function() { e.preventDefault(); e.stopPropagation(); - if (confirm('Are you sure you want to remove this bookmark' + + if (confirm('Are you sure you want to remove this bookmark' + (bookmark.children.length > 0 ? ' and all its children?' : '?'))) { removeBookmark(bookmark.id); } }); headerRight.appendChild(quickAddChildButton); - headerRight.appendChild(quickAddSiblingButton); + headerRight.appendChild(quickAddSiblingButton); headerRight.appendChild(quickRemoveButton); // Assemble header @@ -650,4 +650,4 @@ document.addEventListener('DOMContentLoaded', function() { }); } }); -}); \ No newline at end of file +}); diff --git a/stirling-pdf/src/test/java/stirling/software/SPDF/controller/api/MergeControllerTest.java b/stirling-pdf/src/test/java/stirling/software/SPDF/controller/api/MergeControllerTest.java index 09f0fd92e..4b175b64e 100644 --- a/stirling-pdf/src/test/java/stirling/software/SPDF/controller/api/MergeControllerTest.java +++ b/stirling-pdf/src/test/java/stirling/software/SPDF/controller/api/MergeControllerTest.java @@ -276,4 +276,4 @@ class MergeControllerTest { verify(mockMergedDocument, never()).addPage(any(PDPage.class)); } -} \ No newline at end of file +}