change requests

This commit is contained in:
EthanHealy01 2025-09-16 17:36:54 +01:00
parent aa3797cb22
commit 792140a36f
4 changed files with 3 additions and 28 deletions

View File

@ -19,7 +19,7 @@ const RemoveBlanksSettings = ({ parameters, onParameterChange, disabled = false
label={t('removeBlanks.threshold.label', 'Pixel Whiteness Threshold')} label={t('removeBlanks.threshold.label', 'Pixel Whiteness Threshold')}
value={parameters.threshold} value={parameters.threshold}
onChange={(v) => onParameterChange('threshold', typeof v === 'string' ? Number(v) : v)} onChange={(v) => onParameterChange('threshold', typeof v === 'string' ? Number(v) : v)}
unit={t('removeBlanks.threshold.unit', '')} unit=''
min={0} min={0}
max={255} max={255}
disabled={disabled} disabled={disabled}
@ -31,7 +31,7 @@ const RemoveBlanksSettings = ({ parameters, onParameterChange, disabled = false
label={t('removeBlanks.whitePercent.label', 'White Percent')} label={t('removeBlanks.whitePercent.label', 'White Percent')}
value={parameters.whitePercent} value={parameters.whitePercent}
onChange={(v) => onParameterChange('whitePercent', typeof v === 'string' ? Number(v) : v)} onChange={(v) => onParameterChange('whitePercent', typeof v === 'string' ? Number(v) : v)}
unit={t('removeBlanks.whitePercent.unit', '%')} unit='%'
min={0.1} min={0.1}
max={100} max={100}
disabled={disabled} disabled={disabled}

View File

@ -19,7 +19,6 @@ export const removeBlanksOperationConfig = {
buildFormData: buildRemoveBlanksFormData, buildFormData: buildRemoveBlanksFormData,
operationType: 'remove-blanks', operationType: 'remove-blanks',
endpoint: '/api/v1/misc/remove-blanks', endpoint: '/api/v1/misc/remove-blanks',
filePrefix: 'noblank_',
defaultParameters, defaultParameters,
} as const satisfies ToolOperationConfig<RemoveBlanksParameters>; } as const satisfies ToolOperationConfig<RemoveBlanksParameters>;
@ -35,7 +34,6 @@ export const useRemoveBlanksOperation = () => {
return useToolOperation<RemoveBlanksParameters>({ return useToolOperation<RemoveBlanksParameters>({
...removeBlanksOperationConfig, ...removeBlanksOperationConfig,
responseHandler, responseHandler,
filePrefix: t('removeBlanks.filenamePrefix', 'noblank') + '_',
getErrorMessage: createStandardErrorHandler( getErrorMessage: createStandardErrorHandler(
t('removeBlanks.error.failed', 'Failed to remove blank pages') t('removeBlanks.error.failed', 'Failed to remove blank pages')
) )

View File

@ -17,7 +17,6 @@ export const removePagesOperationConfig = {
buildFormData: buildRemovePagesFormData, buildFormData: buildRemovePagesFormData,
operationType: 'remove-pages', operationType: 'remove-pages',
endpoint: '/api/v1/general/remove-pages', endpoint: '/api/v1/general/remove-pages',
filePrefix: 'removed_pages_',
defaultParameters, defaultParameters,
} as const satisfies ToolOperationConfig<RemovePagesParameters>; } as const satisfies ToolOperationConfig<RemovePagesParameters>;
@ -34,7 +33,6 @@ export const useRemovePagesOperation = () => {
return useToolOperation<RemovePagesParameters>({ return useToolOperation<RemovePagesParameters>({
...removePagesOperationConfig, ...removePagesOperationConfig,
responseHandler, responseHandler,
filePrefix: t('removePages.filenamePrefix', 'removed_pages') + '_',
getErrorMessage: createStandardErrorHandler( getErrorMessage: createStandardErrorHandler(
t('removePages.error.failed', 'Failed to remove pages') t('removePages.error.failed', 'Failed to remove pages')
) )

View File

@ -1,4 +1,3 @@
import { useState, useEffect } from "react";
import { useTranslation } from "react-i18next"; import { useTranslation } from "react-i18next";
import { createToolFlow } from "../components/tools/shared/createToolFlow"; import { createToolFlow } from "../components/tools/shared/createToolFlow";
import { BaseToolProps, ToolComponent } from "../types/tool"; import { BaseToolProps, ToolComponent } from "../types/tool";
@ -19,23 +18,6 @@ const RemoveBlanks = (props: BaseToolProps) => {
props props
); );
// Step expansion state management
const [expandedStep, setExpandedStep] = useState<"files" | "settings" | null>("files");
// Auto-expand settings when files are selected
useEffect(() => {
if (base.selectedFiles.length > 0 && expandedStep === "files") {
setExpandedStep("settings");
}
}, [base.selectedFiles.length, expandedStep]);
// Collapse all steps when results appear
useEffect(() => {
if (base.hasResults) {
setExpandedStep(null);
}
}, [base.hasResults]);
const settingsContent = ( const settingsContent = (
<RemoveBlanksSettings <RemoveBlanksSettings
parameters={base.params.parameters} parameters={base.params.parameters}
@ -47,9 +29,6 @@ const RemoveBlanks = (props: BaseToolProps) => {
const handleSettingsClick = () => { const handleSettingsClick = () => {
if (base.hasResults) { if (base.hasResults) {
base.handleSettingsReset(); base.handleSettingsReset();
} else {
if (!base.hasFiles) return;
setExpandedStep(expandedStep === "settings" ? null : "settings");
} }
}; };
@ -61,7 +40,7 @@ const RemoveBlanks = (props: BaseToolProps) => {
steps: [ steps: [
{ {
title: t("removeBlanks.settings.title", "Settings"), title: t("removeBlanks.settings.title", "Settings"),
isCollapsed: expandedStep !== "settings", isCollapsed: base.settingsCollapsed,
onCollapsedClick: handleSettingsClick, onCollapsedClick: handleSettingsClick,
content: settingsContent, content: settingsContent,
tooltip: tooltipContent, tooltip: tooltipContent,