From 9a0dad8bd7f2ae4333dab78d6313c5d95c4ac9b8 Mon Sep 17 00:00:00 2001
From: Ryan Tang <84262952+ryantang247@users.noreply.github.com>
Date: Wed, 5 Mar 2025 16:45:01 +0800
Subject: [PATCH] Fix highlighter (#3113)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

# Description of Changes

- Added the missing highlighter icon to the View PDF section

Closes #(2873)
https://github.com/Stirling-Tools/Stirling-PDF/issues/2873

---

## Checklist

### General

- [✅](https://emojipedia.org/check-mark-button)] I have read the
[Contribution
Guidelines](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/CONTRIBUTING.md)
- [✅](https://emojipedia.org/check-mark-button) ] I have read the
[Stirling-PDF Developer
Guide](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/DeveloperGuide.md)
(if applicable)
- [✅](https://emojipedia.org/check-mark-button) ] I have read the [How
to add new languages to
Stirling-PDF](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/HowToAddNewLanguage.md)
(if applicable)
- [✅] I have performed a self-review of my own code
- [✅] My changes generate no new warnings


### UI Changes (if applicable)


![image](https://github.com/user-attachments/assets/b7700669-ac26-4b08-aa5d-ea35110eb19e)
---
 src/main/resources/templates/view-pdf.html | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

diff --git a/src/main/resources/templates/view-pdf.html b/src/main/resources/templates/view-pdf.html
index 8d3836cfd..19e42fd56 100644
--- a/src/main/resources/templates/view-pdf.html
+++ b/src/main/resources/templates/view-pdf.html
@@ -360,15 +360,14 @@ See https://github.com/adobe-type-tools/cmap-resources
             </div>
             <div id="toolbarViewerRight">
               <div id="editorModeButtons" class="splitToolbarButton toggled" role="radiogroup">
-                <button id="editorHighlight" class="toolbarButton" hidden="true" disabled="disabled" title="Highlight"
-                  role="radio" aria-checked="false" aria-controls="editorHighlightParamsToolbar" tabindex="31"
-                  data-l10n-id="pdfjs-editor-highlight-button">
-                  <span data-l10n-id="pdfjs-editor-highlight-button-label">Highlight</span>
-                </button>
                 <a id="backToHome" class="toolbarButton hiddenMediumView" title="Back to Main Page" role="radio"
-                  aria-checked="false" tabindex="32" th:href="@{'/'}">
+                  aria-checked="false" tabindex="31" th:href="@{'/'}">
                   <span data-l10n-id="pdfjs-open-file-button-label">Back to Main Page</span>
                 </a>
+                <button id="editorHighlight" class="toolbarButton hiddenMediumView" title="Highlight" role="radio"
+                aria-checked="false" tabindex="32" aria-expanded="false" aria-controls="editorHighlightParamsToolbar">
+                 <span data-l10n-id="pdfjs-editor-highlight-button-label">Highlight</span>
+               </button>
                 <button id="openFile" class="toolbarButton hiddenMediumView" title="Open File" role="radio"
                   aria-checked="false" tabindex="33" data-l10n-id="pdfjs-open-file-button">
                   <span data-l10n-id="pdfjs-open-file-button-label">Open</span>
@@ -389,7 +388,6 @@ See https://github.com/adobe-type-tools/cmap-resources
               </div>
 
               <div id="editorModeSeparator" class="verticalToolbarSeparator"></div>
-
               <button id="editorFreeText" class="toolbarButton hiddenMediumView" title="Text" tabindex="41"
                 data-l10n-id="pdfjs-editor-free-text-button">
                 <span data-l10n-id="pdfjs-editor-free-text-button-label">Text</span>