From d44ba30a3015489723bcac103843ad4edc9ce013 Mon Sep 17 00:00:00 2001
From: Connor Yoh <connor@stirlingpdf.com>
Date: Thu, 7 Aug 2025 12:01:06 +0100
Subject: [PATCH] Fix unit tests

---
 .../tools/convert/useConvertOperation.ts      |  3 +
 .../tests/convert/ConvertIntegration.test.tsx | 55 ++++++++++++++++---
 .../ConvertSmartDetectionIntegration.test.tsx | 28 +++++++++-
 3 files changed, 75 insertions(+), 11 deletions(-)

diff --git a/frontend/src/hooks/tools/convert/useConvertOperation.ts b/frontend/src/hooks/tools/convert/useConvertOperation.ts
index 2d2756b53..ada920e0b 100644
--- a/frontend/src/hooks/tools/convert/useConvertOperation.ts
+++ b/frontend/src/hooks/tools/convert/useConvertOperation.ts
@@ -358,6 +358,9 @@ export const useConvertOperation = (): ConvertOperationHook => {
       setDownloadFilename(convertedFile.name);
       setStatus(t("downloadComplete"));
 
+      // Update local files state for hook consumers
+      setFiles([convertedFile]);
+      
       await addFiles([convertedFile]);
       markOperationApplied(fileId, operationId);
     } catch (error: any) {
diff --git a/frontend/src/tests/convert/ConvertIntegration.test.tsx b/frontend/src/tests/convert/ConvertIntegration.test.tsx
index c9a636035..5ac978810 100644
--- a/frontend/src/tests/convert/ConvertIntegration.test.tsx
+++ b/frontend/src/tests/convert/ConvertIntegration.test.tsx
@@ -23,13 +23,31 @@ import axios from 'axios';
 vi.mock('axios');
 const mockedAxios = vi.mocked(axios);
 
-// Mock utility modules
-vi.mock('../../utils/thumbnailUtils', () => ({
-  generateThumbnailForFile: vi.fn().mockResolvedValue('data:image/png;base64,fake-thumbnail')
+// Mock only essential services that are actually called by the tests
+vi.mock('../../services/fileStorage', () => ({
+  fileStorage: {
+    init: vi.fn().mockResolvedValue(undefined),
+    storeFile: vi.fn().mockImplementation((file, thumbnail) => {
+      return Promise.resolve({ 
+        id: `mock-id-${file.name}`, 
+        name: file.name,
+        size: file.size,
+        type: file.type,
+        lastModified: file.lastModified,
+        thumbnail: thumbnail
+      });
+    }),
+    getAllFileMetadata: vi.fn().mockResolvedValue([]),
+    cleanup: vi.fn().mockResolvedValue(undefined)
+  }
 }));
 
-vi.mock('../../utils/api', () => ({
-  makeApiUrl: vi.fn((path: string) => `/api/v1${path}`)
+vi.mock('../../services/thumbnailGenerationService', () => ({
+  thumbnailGenerationService: {
+    generateThumbnail: vi.fn().mockResolvedValue('data:image/png;base64,fake-thumbnail'),
+    cleanup: vi.fn(),
+    destroy: vi.fn()
+  }
 }));
 
 // Create realistic test files
@@ -194,7 +212,14 @@ describe('Convert Tool Integration Tests', () => {
     
     test('should correctly map image conversion parameters to API call', async () => {
       const mockBlob = new Blob(['fake-data'], { type: 'image/jpeg' });
-      mockedAxios.post.mockResolvedValueOnce({ data: mockBlob });
+      mockedAxios.post.mockResolvedValueOnce({ 
+        data: mockBlob,
+        status: 200,
+        headers: {
+          'content-type': 'image/jpeg',
+          'content-disposition': 'attachment; filename="test_converted.jpg"'
+        }
+      });
 
       const { result } = renderHook(() => useConvertOperation(), {
         wrapper: TestWrapper
@@ -472,7 +497,14 @@ describe('Convert Tool Integration Tests', () => {
     
     test('should record operation in FileContext', async () => {
       const mockBlob = new Blob(['fake-data'], { type: 'image/png' });
-      mockedAxios.post.mockResolvedValueOnce({ data: mockBlob });
+      mockedAxios.post.mockResolvedValueOnce({ 
+        data: mockBlob,
+        status: 200,
+        headers: {
+          'content-type': 'image/png',
+          'content-disposition': 'attachment; filename="test_converted.png"'
+        }
+      });
 
       const { result } = renderHook(() => useConvertOperation(), {
         wrapper: TestWrapper
@@ -506,7 +538,14 @@ describe('Convert Tool Integration Tests', () => {
 
     test('should clean up blob URLs on reset', async () => {
       const mockBlob = new Blob(['fake-data'], { type: 'image/png' });
-      mockedAxios.post.mockResolvedValueOnce({ data: mockBlob });
+      mockedAxios.post.mockResolvedValueOnce({ 
+        data: mockBlob,
+        status: 200,
+        headers: {
+          'content-type': 'image/png',
+          'content-disposition': 'attachment; filename="test_converted.png"'
+        }
+      });
 
       const { result } = renderHook(() => useConvertOperation(), {
         wrapper: TestWrapper
diff --git a/frontend/src/tests/convert/ConvertSmartDetectionIntegration.test.tsx b/frontend/src/tests/convert/ConvertSmartDetectionIntegration.test.tsx
index 3fac5b4ba..64aafc488 100644
--- a/frontend/src/tests/convert/ConvertSmartDetectionIntegration.test.tsx
+++ b/frontend/src/tests/convert/ConvertSmartDetectionIntegration.test.tsx
@@ -18,9 +18,31 @@ import { detectFileExtension } from '../../utils/fileUtils';
 vi.mock('axios');
 const mockedAxios = vi.mocked(axios);
 
-// Mock utility modules
-vi.mock('../../utils/thumbnailUtils', () => ({
-  generateThumbnailForFile: vi.fn().mockResolvedValue('data:image/png;base64,fake-thumbnail')
+// Mock only essential services that are actually called by the tests
+vi.mock('../../services/fileStorage', () => ({
+  fileStorage: {
+    init: vi.fn().mockResolvedValue(undefined),
+    storeFile: vi.fn().mockImplementation((file, thumbnail) => {
+      return Promise.resolve({ 
+        id: `mock-id-${file.name}`, 
+        name: file.name,
+        size: file.size,
+        type: file.type,
+        lastModified: file.lastModified,
+        thumbnail: thumbnail
+      });
+    }),
+    getAllFileMetadata: vi.fn().mockResolvedValue([]),
+    cleanup: vi.fn().mockResolvedValue(undefined)
+  }
+}));
+
+vi.mock('../../services/thumbnailGenerationService', () => ({
+  thumbnailGenerationService: {
+    generateThumbnail: vi.fn().mockResolvedValue('data:image/png;base64,fake-thumbnail'),
+    cleanup: vi.fn(),
+    destroy: vi.fn()
+  }
 }));
 
 const TestWrapper: React.FC<{ children: React.ReactNode }> = ({ children }) => (