From ea46204c6ec83410578faf1a890e5193953f7a92 Mon Sep 17 00:00:00 2001 From: Mathieu Hirel <1053712+ralmn@users.noreply.github.com> Date: Wed, 12 Feb 2025 23:16:30 +0100 Subject: [PATCH] fix: Allow Entry overflow when text is too long (#2940) # Description of Changes In the French language, some entries on the home page have overlapping when the text is on 3 lines. Before : ![image](https://github.com/user-attachments/assets/38cf2912-47dc-42a4-9634-9069345840c4) After : ![image](https://github.com/user-attachments/assets/5ea43d9b-3f77-46d8-a603-aa2796c13306) --- ## Checklist ### General - [x] I have read the [Contribution Guidelines](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/CONTRIBUTING.md) - [x] I have read the [Stirling-PDF Developer Guide](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/DeveloperGuide.md) (if applicable) - [x] I have read the [How to add new languages to Stirling-PDF](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/HowToAddNewLanguage.md) (if applicable) - [x] I have performed a self-review of my own code - [x] My changes generate no new warnings ### Documentation - [x] I have updated relevant docs on [Stirling-PDF's doc repo](https://github.com/Stirling-Tools/Stirling-Tools.github.io/blob/main/docs/) (if functionality has heavily changed) - [x] I have read the section [Add New Translation Tags](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/HowToAddNewLanguage.md#add-new-translation-tags) (for new translation tags only) ### UI Changes (if applicable) - [x] Screenshots or videos demonstrating the UI changes are attached (e.g., as comments or direct attachments in the PR) ### Testing (if applicable) - [x] I have tested my changes locally. Refer to the [Testing Guide](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/DeveloperGuide.md#6-testing) for more details. --- src/main/resources/templates/fragments/navbarEntry.html | 4 ++-- src/main/resources/templates/fragments/navbarEntryCustom.html | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/main/resources/templates/fragments/navbarEntry.html b/src/main/resources/templates/fragments/navbarEntry.html index 75166d622..42f696bfb 100644 --- a/src/main/resources/templates/fragments/navbarEntry.html +++ b/src/main/resources/templates/fragments/navbarEntry.html @@ -4,7 +4,7 @@ th:if="${@endpointConfiguration.isEndpointEnabled(endpoint)}"> th:data-bs-link="@{${endpoint}}" th:classappend="${endpoint.equals(currentPage)} ? ${toolGroup} + ' active' : '' + ${toolGroup}" th:data-bs-tags="#{${tagKey}}" th:data-bs-title='#{${titleKey}}'> -
@@ -15,4 +15,4 @@ th:if="${@endpointConfiguration.isEndpointEnabled(endpoint)}"> - \ No newline at end of file + diff --git a/src/main/resources/templates/fragments/navbarEntryCustom.html b/src/main/resources/templates/fragments/navbarEntryCustom.html index c9cdb4f17..c3b2ad848 100644 --- a/src/main/resources/templates/fragments/navbarEntryCustom.html +++ b/src/main/resources/templates/fragments/navbarEntryCustom.html @@ -4,7 +4,7 @@ th:data-bs-link="@{${endpoint}}" th:classappend="${endpoint.equals(currentPage)} ? ${toolGroup} + ' active' : '' + ${toolGroup}" th:data-bs-tags="#{${tagKey}}" th:data-bs-title='#{${titleKey}}'> -
@@ -18,4 +18,4 @@ - \ No newline at end of file +