From fd10e5db10054f74e3f8d7fb31eb2016c6ec2cfc Mon Sep 17 00:00:00 2001 From: Ludy Date: Tue, 1 Jul 2025 16:49:58 +0200 Subject: [PATCH] chore: include ignore_translation.toml in README sync commit (#3845) # Description of Changes - Updated the GitHub Actions workflow `.github/workflows/sync_files.yml` to also include `scripts/ignore_translation.toml` in the automatic commit step. - This TOML file lists translatable strings that should be excluded because they are explicitly marked as non-translatable. - Including it in the sync ensures that cleanup of such excluded strings is versioned together with README changes, improving consistency of translation tooling automation. --- ## Checklist ### General - [x] I have read the [Contribution Guidelines](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/CONTRIBUTING.md) - [x] I have read the [Stirling-PDF Developer Guide](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/DeveloperGuide.md) (if applicable) - [ ] I have read the [How to add new languages to Stirling-PDF](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/HowToAddNewLanguage.md) (if applicable) - [x] I have performed a self-review of my own code - [x] My changes generate no new warnings ### Documentation - [ ] I have updated relevant docs on [Stirling-PDF's doc repo](https://github.com/Stirling-Tools/Stirling-Tools.github.io/blob/main/docs/) (if functionality has heavily changed) - [ ] I have read the section [Add New Translation Tags](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/HowToAddNewLanguage.md#add-new-translation-tags) (for new translation tags only) ### UI Changes (if applicable) - [ ] Screenshots or videos demonstrating the UI changes are attached (e.g., as comments or direct attachments in the PR) ### Testing (if applicable) - [ ] I have tested my changes locally. Refer to the [Testing Guide](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/DeveloperGuide.md#6-testing) for more details. --- .github/workflows/sync_files.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/sync_files.yml b/.github/workflows/sync_files.yml index 84f5bb3d1..cf5ecbc5c 100644 --- a/.github/workflows/sync_files.yml +++ b/.github/workflows/sync_files.yml @@ -57,8 +57,8 @@ jobs: - name: Run git add run: | - git add README.md - git diff --staged --quiet || git commit -m ":memo: Sync README.md" || echo "No changes detected" + git add README.md scripts/ignore_translation.toml + git diff --staged --quiet || git commit -m ":memo: Sync README.md & scripts/ignore_translation.toml" || echo "No changes detected" - name: Create Pull Request if: always()