saulteafarmer/Stirling-PDF
1
0
Fork 0
mirror of https://github.com/Stirling-Tools/Stirling-PDF.git synced 2025-06-22 23:45:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

Hardening suggestions for Stirling-PDF / audit2 (#3758)

Browse Source 
I've reviewed the recently opened PR ([3739 - Auditing
support](https://github.com/Stirling-Tools/Stirling-PDF/pull/3739)) and
have identified some area(s) that could benefit from additional
hardening measures.

These changes should help prevent potential security vulnerabilities and
improve overall code quality.

Thank you for your consideration!
🧚🤖  Powered by Pixeebot  

[Feedback](https://ask.pixee.ai/feedback) |
[Community](https://pixee-community.slack.com/signup#/domain-signup) |
[Docs](https://docs.pixee.ai/)
![](https://d1zaessa2hpsmj.cloudfront.net/pixel/v1/track?writeKey=2PI43jNm7atYvAuK7rJUz3Kcd6A&event=PR_HARDENING%7CStirling-Tools%2FStirling-PDF%7C911c89402362b71e4c59eff8c459d4942aeda6c8)

Co-authored-by: pixeebot[bot] <104101892+pixeebot[bot]@users.noreply.github.com>
This commit is contained in:
pixeebot[bot] 2025-06-17 19:43:04 +01:00 committed by GitHub
parent 911c894023
commit fe4cb9058c
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
proprietary/src/main/java/stirling/software/proprietary/web/CorrelationIdFilter.java
View File

@ -1,5 +1,6 @@
package stirling.software.proprietary.web; package stirling.software.proprietary.web;
import io.github.pixee.security.Newlines;
import jakarta.servlet.FilterChain; import jakarta.servlet.FilterChain;
import jakarta.servlet.ServletException; import jakarta.servlet.ServletException;
import jakarta.servlet.http.HttpServletRequest; import jakarta.servlet.http.HttpServletRequest;
@ -36,11 +37,11 @@ public class CorrelationIdFilter extends OncePerRequestFilter {
} }
req.setAttribute(MDC_KEY, id); req.setAttribute(MDC_KEY, id);
MDC.put(MDC_KEY, id); MDC.put(MDC_KEY, id);
res.setHeader(HEADER, id); res.setHeader(HEADER, Newlines.stripAll(id));
chain.doFilter(req, res); chain.doFilter(req, res);
} finally { } finally {
MDC.remove(MDC_KEY); MDC.remove(MDC_KEY);
} }
} }
} }