Omar Ahmed Hassan
b4451da2f4
Fix displayed identical fonts in sign PDF ( #2751 )
...
# Description of Changes
### Changes:
- Add a new custom select to display fonts correctly and to allow more
styling flexibility in Sign PDF feature by hiding the original
`<select>` element (`display: none;`) and wrap it with a `<div>` and
then create a custom selection menu using `<div>`s and CSS to achieve
the required results due to the limitations of `<select>` and `<option>`
while still preserving the hidden `<select>` for form submission.
### Why was the change made?
1. A bug that caused font families to not be displayed in Firefox.
2. Select/Option element are not flexible when it comes to styling
(compared to DIVs for example) but bullet point `1.` is of higher
priority.
### UI Changes:
- Dark Mode:
- Before:
- After:
- Light Mode:
- Before:
- After:
Note:
- Changes in `sign.js` are between the lines 95-228, as it seems the
file was auto-formatted affecting whitespaces and
single_quotes/double_quotes.
#### Useful quotes from MDN:
> [Styling with
CSS](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/option#styling_with_css )
Styling the <option> element is highly limited. Options don't inherit
the font set on the parent. In Firefox, only
[color](https://developer.mozilla.org/en-US/docs/Web/CSS/color ) and
[background-color](https://developer.mozilla.org/en-US/docs/Web/CSS/background-color )
can be set, however in Chrome and Safari it's not possible to set any
properties. You can find more details about styling in [our guide to
advanced form
styling](https://developer.mozilla.org/en-US/docs/Learn_web_development/Extensions/Forms/Advanced_form_styling ).
#### Useful references:
- [Option
Element](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/option#styling_with_css )
- [Select
Element](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/select )
- [Advanced Form
Styling](https://developer.mozilla.org/en-US/docs/Learn_web_development/Extensions/Forms/Advanced_form_styling )
Closes #1575
---
## Checklist
### General
- [x] I have read the [Contribution
Guidelines](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/CONTRIBUTING.md )
- [x] I have read the [Stirling-PDF Developer
Guide](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/DeveloperGuide.md )
(if applicable)
- [ ] I have read the [How to add new languages to
Stirling-PDF](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/HowToAddNewLanguage.md )
(if applicable)
- [x] I have performed a self-review of my own code
- [x] My changes generate no new warnings
### Documentation
- [ ] I have updated relevant docs on [Stirling-PDF's doc
repo](https://github.com/Stirling-Tools/Stirling-Tools.github.io/blob/main/docs/ )
(if functionality has heavily changed)
- [ ] I have read the section [Add New Translation
Tags](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/HowToAddNewLanguage.md#add-new-translation-tags )
(for new translation tags only)
### UI Changes (if applicable)
- [x] Screenshots or videos demonstrating the UI changes are attached
(e.g., as comments or direct attachments in the PR)
### Testing (if applicable)
- [x] I have tested my changes locally. Refer to the [Testing
Guide](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/DeveloperGuide.md#6-testing )
for more details.
2025-01-20 12:11:31 +00:00
reecebrowne
49fb634690
Feature/improved signature element ( #2489 )
...
# Description
Please provide a summary of the changes, including relevant motivation
and context.
Closes #(issue_number)
## Checklist
- [ ] I have read the [Contribution
Guidelines](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/CONTRIBUTING.md )
- [ ] I have performed a self-review of my own code
- [ ] I have attached images of the change if it is UI based
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] If my code has heavily changed functionality I have updated
relevant docs on [Stirling-PDFs doc
repo](https://github.com/Stirling-Tools/Stirling-Tools.github.io/blob/main/docs/ )
- [ ] My changes generate no new warnings
- [ ] I have read the section [Add New Translation
Tags](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/HowToAddNewLanguage.md#add-new-translation-tags )
(for new translation tags only)
---------
Co-authored-by: Anthony Stirling <77850077+Frooodle@users.noreply.github.com>
Co-authored-by: Reece Browne <reece@stirling.pdf>
2025-01-02 15:49:29 +00:00
Renan
204bae3bc1
Sign multiple PDF pages at the same time in the same location ( #2008 ) ( #2278 )
...
* Sign multiple PDF pages at the same time in the same location (#2008 )
* Modifying the functionality of how the signature is added to all pages (#2008 )
* Adding the functionality to reverse the addition on all pages and implementing buttons to navigate to the first and last pages (#2008 )
2024-11-22 17:40:09 +00:00
Anthony Stirling
27d2681a97
Feature/save signs ( #2127 )
...
* apply fix
* Fixes empty th:action
* Update build.gradle
* fix
* formatting
* Save signatures
* Fix code scanning alert no. 42: Uncontrolled data used in path expression
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
* fix UserServiceInterface
* Merge branch 'feature/saveSigns' of
git@github.com:Stirling-Tools/Stirling-PDF.git into feature/saveSigns
* 0.31.0 bump and further csrf
* formatting
* preview name
* add
* sign doc
* Update translation files (#2128 )
Signed-off-by: GitHub Action <action@github.com>
Co-authored-by: GitHub Action <action@github.com>
---------
Signed-off-by: GitHub Action <action@github.com>
Co-authored-by: Dimitrios Kaitantzidis <james_k23@hotmail.gr>
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Co-authored-by: a <a>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: GitHub Action <action@github.com>
2024-10-30 12:46:44 +00:00
Anthony Stirling
cae8cd0aa9
Add on hover color to sign ( #2059 )
...
* Fixed layering issue with z-index, and added smoother transitions for… (#1996 )
Fixed layering issue with z-index, and added smoother transitions for signing
Co-authored-by: Anthony Stirling <77850077+Frooodle@users.noreply.github.com>
* Delete package-lock.json
---------
Co-authored-by: Surya Karthikeyan Vijayalakshmi <108506548+SuryaKV101@users.noreply.github.com>
2024-10-22 00:44:22 +01:00
Ludy
e4a76e96af
HTML, CSS, JS and JAVA corrections ( #810 )
...
* CSS corrections
* HTML corrections
* JS corrections
* JAVA corrections
* remove tab
* CSS corrections 2
* JS corrections 2
* back to the roots
* max-linie 127
* add slash hr|br
* return bootstrap-icons.css
* return bootstrap-icons.min.css
* return bootstrap.min.css
* Update bootstrap-icons.css
* Update bootstrap-icons.min.css
* Update bootstrap-icons.min.css
* Update bootstrap.min.css
* CSS corrections
* HTML corrections
* JS corrections
* JAVA corrections
* remove tab
* CSS corrections 2
* JS corrections 2
* back to the roots
* max-linie 127
* add slash hr|br
* return bootstrap-icons.css
* Update bootstrap-icons.css
* Bootstrap CSS
* Update prism.css
2024-02-16 21:49:06 +00:00
