Merge branch 'V2' into V2-eslint-ban-ts-comment

Enable ESLint no-unused-expressions rule (#4363 )
# Description of Changes Enable ESLint [no-unused-expressions rule](https://typescript-eslint.io/rules/no-unused-expressions/)
2025-09-24 12:36:13 +00:00 · 2025-09-04 16:13:31 +01:00 · 2025-09-04 15:12:38 +00:00 · 2025-09-04 15:09:29 +00:00 · 2025-09-04 15:04:49 +00:00 · 2025-09-04 15:59:31 +01:00
8 changed files with 23 additions and 27 deletions
--- a/frontend/eslint.config.mjs
+++ b/frontend/eslint.config.mjs
@ -15,16 +15,12 @@ export default defineConfig(
  },
  {
    rules: {
-      "no-empty": "off", // Temporarily disabled until codebase conformant
      "no-empty-pattern": "off", // Temporarily disabled until codebase conformant
      "no-undef": "off", // Temporarily disabled until codebase conformant
-      "no-useless-escape": "off", // Temporarily disabled until codebase conformant
      "no-case-declarations": "off", // Temporarily disabled until codebase conformant
-      "prefer-const": "off", // Temporarily disabled until codebase conformant
      "@typescript-eslint/no-empty-object-type": "off", // Temporarily disabled until codebase conformant
      "@typescript-eslint/no-explicit-any": "off", // Temporarily disabled until codebase conformant
      "@typescript-eslint/no-require-imports": "off", // Temporarily disabled until codebase conformant
-      "@typescript-eslint/no-unused-expressions": "off", // Temporarily disabled until codebase conformant
      "@typescript-eslint/no-unused-vars": "off", // Temporarily disabled until codebase conformant
    },
  }
--- a/frontend/scripts/generate-licenses.js
+++ b/frontend/scripts/generate-licenses.js
@ -224,7 +224,7 @@ function getLicenseUrl(licenseType) {
    // Handle complex SPDX expressions like "(MIT AND Zlib)" or "(MIT OR CC0-1.0)"
    if (licenseType.includes('AND') || licenseType.includes('OR')) {
        // Extract the first license from compound expressions for URL
-        const match = licenseType.match(/\(?\s*([A-Za-z0-9\-\.]+)/);
+        const match = licenseType.match(/\(?\s*([A-Za-z0-9\-.]+)/);
        if (match && licenseUrls[match[1]]) {
            return licenseUrls[match[1]];
        }
--- a/frontend/src/components/shared/fitText/textFit.ts
+++ b/frontend/src/components/shared/fitText/textFit.ts
@ -82,8 +82,8 @@ export function adjustFontSizeToFit(

  return () => {
    cancelAnimationFrame(raf);
-    try { ro.disconnect(); } catch {}
-    try { mo.disconnect(); } catch {}
+    try { ro.disconnect(); } catch { /* Ignore errors */ }
+    try { mo.disconnect(); } catch { /* Ignore errors */ }
  };
 }

--- a/frontend/src/components/tools/toolPicker/ToolSearch.tsx
+++ b/frontend/src/components/tools/toolPicker/ToolSearch.tsx
@ -126,7 +126,7 @@ const ToolSearch = ({
                key={id}
                variant="subtle"
                onClick={() => {
-                  onToolSelect && onToolSelect(id);
+                  onToolSelect?.(id);
                  setDropdownOpen(false);
                }}
                leftSection={<div style={{ color: "var(--tools-text-and-icon-color)" }}>{tool.icon}</div>}
--- a/frontend/src/index.tsx
+++ b/frontend/src/index.tsx
@ -35,8 +35,11 @@ function updatePosthogConsent(){
      return;
    }
    const optIn = (window.CookieConsent as any).acceptedCategory('analytics');
-    optIn?
-      posthog.opt_in_capturing() : posthog.opt_out_capturing();
+    if (optIn) {
+      posthog.opt_in_capturing();
+    } else {
+      posthog.opt_out_capturing();
+    }

    console.log("Updated analytics consent: ", optIn? "opted in" : "opted out");
  }
--- a/frontend/src/services/enhancedPDFProcessingService.ts
+++ b/frontend/src/services/enhancedPDFProcessingService.ts
@ -519,10 +519,7 @@ export class EnhancedPDFProcessingService {
    this.notifyListeners();

    // Force memory cleanup hint
-    if (typeof window !== 'undefined' && window.gc) {
-      let gc = window.gc;
-      setTimeout(() => gc(), 100);
-    }
+    setTimeout(() => window.gc?.(), 100);
  }

  /**
--- a/frontend/src/services/indexedDBManager.ts
+++ b/frontend/src/services/indexedDBManager.ts
@ -92,8 +92,6 @@ class IndexedDBManager {

        // Create or update object stores
        config.stores.forEach(storeConfig => {
-          let store: IDBObjectStore;
-
          if (db.objectStoreNames.contains(storeConfig.name)) {
            // Store exists - for now, just continue (could add migration logic here)
            console.log(`Object store '${storeConfig.name}' already exists`);
@ -109,7 +107,7 @@ class IndexedDBManager {
            options.autoIncrement = storeConfig.autoIncrement;
          }

-          store = db.createObjectStore(storeConfig.name, options);
+          const store = db.createObjectStore(storeConfig.name, options);
          console.log(`Created object store '${storeConfig.name}'`);

          // Create indexes
--- a/frontend/src/services/pdfWorkerManager.ts
+++ b/frontend/src/services/pdfWorkerManager.ts
@ -94,6 +94,7 @@ class PDFWorkerManager {
        try {
          loadingTask.destroy();
        } catch (destroyError) {
+          // Ignore errors
        }
      }
      throw error;
@ -166,6 +167,7 @@ class PDFWorkerManager {
      try {
        pdf.destroy();
      } catch (error) {
+        // Ignore errors
      }
    });
Author	SHA1	Message	Date
James Brunton	1c8e1da11d	Merge branch 'V2' into V2-eslint-ban-ts-comment	2025-09-04 16:13:31 +01:00
James Brunton	94e8f603ff	Enable ESLint no-unused-expressions rule (#4363 ) # Description of Changes Enable ESLint [no-unused-expressions rule](https://typescript-eslint.io/rules/no-unused-expressions/)	2025-09-04 15:12:38 +00:00
James Brunton	74609e54fe	Enable ESLint prefer-const rule (#4349 ) # Description of Changes Enable ESLint [prefer-const rule](https://eslint.org/docs/latest/rules/prefer-const)	2025-09-04 15:09:29 +00:00
James Brunton	003285506f	Enable ESLint no-useless-escape rule (#4344 ) # Description of Changes Enable ESLint [no-useless-escape rule](https://eslint.org/docs/latest/rules/no-useless-escape)	2025-09-04 15:04:49 +00:00
James Brunton	6d3b08d9b6	Enable ESLint no-empty rule (#4342 ) # Description of Changes Enable ESLint [no-empty rule](https://eslint.org/docs/latest/rules/no-empty)	2025-09-04 15:59:31 +01:00
James Brunton	f6ab5ba9e6	Merge branch 'V2' into V2-eslint-ban-ts-comment	2025-09-04 15:16:49 +01:00
James Brunton	295e682e03	Add linting to frontend (#4341 ) # Description of Changes There's no current linter running over our TypeScript code, which means we've got a bunch of dead code and other code smells around with nothing notifying us. This PR adds ESLint with the typescript-eslint plugin and enables the recommended settings as a starting point for us. I've disabled all of the failing rules for the scope of this PR, just to get linting running without causing a massive diff. I'll follow up with future PRs that enable the failing rules one by one. Also updates our version of TypeScript, which introduces a new type error in the code (which I've had to fix)	2025-09-04 14:08:28 +01:00