mirror of
https://github.com/Stirling-Tools/Stirling-PDF.git
synced 2025-06-23 16:05:09 +00:00

# Description of Changes - **What was changed:** - Removed explicit constructor definitions annotated with `@Autowired` across services, controllers, filters, and schedulers. - Added Lombok’s `@RequiredArgsConstructor` to automatically generate required-args constructors and eliminate boilerplate. - Introduced other Lombok annotations (`@Data`, `@Getter`, `@Setter`, `@EqualsAndHashCode`, `@NoArgsConstructor`) on model and API classes to replace manual getters/setters and constructors. - Standardized string comparisons to use the constant-first form (e.g., `"value".equals(variable)`). - Cleaned up unused imports and organized OpenAPI configuration by extracting default title/description constants. - **Why the change was made:** - To reduce repetitive boilerplate code and improve maintainability. - To leverage Lombok for cleaner, more consistent dependency injection and data modeling. - To ensure a uniform coding style across the entire codebase. #3406 --- ## Checklist ### General - [x] I have read the [Contribution Guidelines](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/CONTRIBUTING.md) - [ ] I have read the [Stirling-PDF Developer Guide](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/DeveloperGuide.md) (if applicable) - [ ] I have read the [How to add new languages to Stirling-PDF](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/HowToAddNewLanguage.md) (if applicable) - [x] I have performed a self-review of my own code - [x] My changes generate no new warnings ### Documentation - [ ] I have updated relevant docs on [Stirling-PDF's doc repo](https://github.com/Stirling-Tools/Stirling-Tools.github.io/blob/main/docs/) (if functionality has heavily changed) - [ ] I have read the section [Add New Translation Tags](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/HowToAddNewLanguage.md#add-new-translation-tags) (for new translation tags only) ### UI Changes (if applicable) - [ ] Screenshots or videos demonstrating the UI changes are attached ### Testing (if applicable) - [ ] I have tested my changes locally. Refer to the [Testing Guide](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/DeveloperGuide.md#6-testing) for more details.
91 lines
3.7 KiB
Java
91 lines
3.7 KiB
Java
package stirling.software.SPDF.service;
|
|
|
|
import java.util.HashMap;
|
|
import java.util.Map;
|
|
import java.util.concurrent.ConcurrentHashMap;
|
|
|
|
import org.slf4j.Logger;
|
|
import org.slf4j.LoggerFactory;
|
|
import org.springframework.scheduling.annotation.Scheduled;
|
|
import org.springframework.stereotype.Service;
|
|
|
|
import io.micrometer.core.instrument.MeterRegistry;
|
|
import io.micrometer.core.instrument.search.Search;
|
|
|
|
import lombok.RequiredArgsConstructor;
|
|
|
|
import stirling.software.SPDF.config.EndpointInspector;
|
|
|
|
@Service
|
|
@RequiredArgsConstructor
|
|
public class MetricsAggregatorService {
|
|
private static final Logger logger = LoggerFactory.getLogger(MetricsAggregatorService.class);
|
|
|
|
private final MeterRegistry meterRegistry;
|
|
private final PostHogService postHogService;
|
|
private final EndpointInspector endpointInspector;
|
|
private final Map<String, Double> lastSentMetrics = new ConcurrentHashMap<>();
|
|
|
|
@Scheduled(fixedRate = 7200000) // Run every 2 hours
|
|
public void aggregateAndSendMetrics() {
|
|
Map<String, Object> metrics = new HashMap<>();
|
|
|
|
final boolean validateGetEndpoints = endpointInspector.getValidGetEndpoints().size() != 0;
|
|
Search.in(meterRegistry)
|
|
.name("http.requests")
|
|
.counters()
|
|
.forEach(
|
|
counter -> {
|
|
String method = counter.getId().getTag("method");
|
|
String uri = counter.getId().getTag("uri");
|
|
// Skip if either method or uri is null
|
|
if (method == null || uri == null) {
|
|
return;
|
|
}
|
|
|
|
// Skip URIs that are 2 characters or shorter
|
|
if (uri.length() <= 2) {
|
|
return;
|
|
}
|
|
|
|
// Skip non-GET and non-POST requests
|
|
if (!"GET".equals(method) && !"POST".equals(method)) {
|
|
return;
|
|
}
|
|
|
|
// For POST requests, only include if they start with /api/v1
|
|
if ("POST".equals(method) && !uri.contains("api/v1")) {
|
|
return;
|
|
}
|
|
|
|
if (uri.contains(".txt")) {
|
|
return;
|
|
}
|
|
// For GET requests, validate if we have a list of valid endpoints
|
|
if ("GET".equals(method)
|
|
&& validateGetEndpoints
|
|
&& !endpointInspector.isValidGetEndpoint(uri)) {
|
|
logger.debug("Skipping invalid GET endpoint: {}", uri);
|
|
return;
|
|
}
|
|
|
|
String key =
|
|
String.format(
|
|
"http_requests_%s_%s", method, uri.replace("/", "_"));
|
|
double currentCount = counter.count();
|
|
double lastCount = lastSentMetrics.getOrDefault(key, 0.0);
|
|
double difference = currentCount - lastCount;
|
|
if (difference > 0) {
|
|
logger.info("{}, {}", key, difference);
|
|
metrics.put(key, difference);
|
|
lastSentMetrics.put(key, currentCount);
|
|
}
|
|
});
|
|
// Send aggregated metrics to PostHog
|
|
if (!metrics.isEmpty()) {
|
|
|
|
postHogService.captureEvent("aggregated_metrics", metrics);
|
|
}
|
|
}
|
|
}
|