mirror of
https://github.com/Stirling-Tools/Stirling-PDF.git
synced 2025-09-11 14:09:23 +00:00

# Description of Changes - **What was changed** - **URL to PDF flow** - Changed `ConvertWebsiteToPDF#urlToPdf` to return `ResponseEntity<?>` and perform a redirect (`303 SEE_OTHER`) back to `/url-to-pdf` with an `error` query param instead of throwing exceptions. - Added alert rendering in `url-to-pdf.html` using `param.error` for localized error display. - Introduced new translation key `error.invalidUrlFormat` in `messages_en_GB.properties`. - **Security / SSRF** - Migrated `ApplicationProperties.System.UrlSecurity.level` from `String` to `SsrfProtectionLevel` enum. - Default now set to `SsrfProtectionLevel.MEDIUM` (`// MAX, MEDIUM, OFF`). - This avoids the issue where setting `OFF` returned `false` in configuration parsing. - Updated `SsrfProtectionService#parseProtectionLevel` accordingly (using `level.name()`). - **Repo hygiene** - Added `**/LOCAL_APPDATA_FONTCONFIG_CACHE/**` to `.gitignore`. - **Why the change was made** - Provide user-friendly, localized error messages instead of exposing internal exceptions on URL-to-PDF conversions. - Ensure SSRF protection level parsing is type-safe and consistent—`OFF` can now be set without yielding a misleading `false` state. - Prevent unwanted fontconfig cache files from being tracked in Git. --- ## Checklist ### General - [x] I have read the [Contribution Guidelines](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/CONTRIBUTING.md) - [x] I have read the [Stirling-PDF Developer Guide](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/devGuide/DeveloperGuide.md) (if applicable) - [ ] I have read the [How to add new languages to Stirling-PDF](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/devGuide/HowToAddNewLanguage.md) (if applicable) - [x] I have performed a self-review of my own code - [x] My changes generate no new warnings ### Documentation - [ ] I have updated relevant docs on [Stirling-PDF's doc repo](https://github.com/Stirling-Tools/Stirling-Tools.github.io/blob/main/docs/) (if functionality has heavily changed) - [ ] I have read the section [Add New Translation Tags](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/devGuide/HowToAddNewLanguage.md#add-new-translation-tags) (for new translation tags only) ### UI Changes (if applicable) - [ ] Screenshots or videos demonstrating the UI changes are attached (e.g., as comments or direct attachments in the PR) ### Testing (if applicable) - [ ] I have tested my changes locally. Refer to the [Testing Guide](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/devGuide/DeveloperGuide.md#6-testing) for more details.