mirror of
https://github.com/Stirling-Tools/Stirling-PDF.git
synced 2025-06-19 22:15:03 +00:00
9bacebf2e9
# Description of Changes ### Before:  ### After:  As I was reviewing my translation I noticed that there is a problem how Convert button is being displayed as "Convert", after further review I realized Eml-To-pdf.html was a bit inconsistent with other HTMLs. This PR updates the `eml-to-pdf.html`, and addresses consistency issues, as well the visual Convert button problem. Updated the `eml-to-pdf.html` template to improve its structure, styling, and functionality. The changes include enhancements to the layout, better handling of dynamic text, and minor code cleanups. ### Layout and Styling Updates: * Added a new block (`th:block`) to include a common game fragment and adjusted the layout by removing extra `<br>` tags and modifying the container structure for better alignment. * Updated the class of a `<div>` element to include `bg-card` for improved styling. ### Functional Improvements: * Refactored the JavaScript to use a pre-defined `submitText` variable for dynamic button text, improving maintainability. ### Code Cleanup: * Removed unnecessary blank lines and improved the indentation for better readability. --- ## Checklist ### General - [x] I have read the [Contribution Guidelines](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/CONTRIBUTING.md) - [x] I have read the [Stirling-PDF Developer Guide](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/DeveloperGuide.md) (if applicable) - [ ] I have read the [How to add new languages to Stirling-PDF](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/HowToAddNewLanguage.md) (if applicable) - [x] I have performed a self-review of my own code - [x] My changes generate no new warnings ### Documentation - [ ] I have updated relevant docs on [Stirling-PDF's doc repo](https://github.com/Stirling-Tools/Stirling-Tools.github.io/blob/main/docs/) (if functionality has heavily changed) - [ ] I have read the section [Add New Translation Tags](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/HowToAddNewLanguage.md#add-new-translation-tags) (for new translation tags only) ### UI Changes (if applicable) - [x] Screenshots or videos demonstrating the UI changes are attached (e.g., as comments or direct attachments in the PR) ### Testing (if applicable) - [x] I have tested my changes locally. Refer to the [Testing Guide](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/DeveloperGuide.md#6-testing) for more details. --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>