From 3d7969d1daea20edcb1e2425b80d160c04dab070 Mon Sep 17 00:00:00 2001 From: Yassine Doghri Date: Mon, 25 Aug 2025 17:08:21 +0000 Subject: [PATCH] chore: fix rector issues with filters' methods return types --- app/Filters/AllowCorsFilter.php | 6 +++--- modules/Api/Rest/V1/Filters/ApiFilter.php | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/app/Filters/AllowCorsFilter.php b/app/Filters/AllowCorsFilter.php index 91e6ed5d..ca64b7ca 100644 --- a/app/Filters/AllowCorsFilter.php +++ b/app/Filters/AllowCorsFilter.php @@ -12,11 +12,11 @@ class AllowCorsFilter implements FilterInterface { /** * @param string[]|null $arguments - * @return RequestInterface|ResponseInterface|string|void + * @return RequestInterface|ResponseInterface|string|null */ public function before(RequestInterface $request, $arguments = null) { - // Do something here + return null; } /** @@ -29,7 +29,7 @@ class AllowCorsFilter implements FilterInterface $response->setHeader('Cache-Control', 'public, max-age=86400'); } - $response->setHeader('Access-Control-Allow-Origin', '*') // for allowing any domain, insecure + return $response->setHeader('Access-Control-Allow-Origin', '*') // for allowing any domain, insecure ->setHeader('Access-Control-Allow-Headers', '*') // for allowing any headers, insecure ->setHeader('Access-Control-Allow-Methods', 'GET, OPTIONS') // allows GET and OPTIONS methods only ->setHeader('Access-Control-Max-Age', '86400'); diff --git a/modules/Api/Rest/V1/Filters/ApiFilter.php b/modules/Api/Rest/V1/Filters/ApiFilter.php index ff0a0715..dee4982c 100644 --- a/modules/Api/Rest/V1/Filters/ApiFilter.php +++ b/modules/Api/Rest/V1/Filters/ApiFilter.php @@ -65,10 +65,10 @@ class ApiFilter implements FilterInterface /** * @param string[]|null $arguments * - * @return ResponseInterface|void + * @return ResponseInterface|null */ public function after(RequestInterface $request, ResponseInterface $response, $arguments = null) { - // Do something here + return null; } }