From ab7b5fc273689e3abb33782e17d955c388d52ce7 Mon Sep 17 00:00:00 2001
From: austinkelsay <austinkelsay@protonmail.com>
Date: Wed, 14 May 2025 16:55:23 -0500
Subject: [PATCH] standardize subscription periods and add null date handling

---
 .../profile/subscription/UserSubscription.js   | 18 ++++++++++++------
 src/pages/about.js                             |  3 ++-
 2 files changed, 14 insertions(+), 7 deletions(-)

diff --git a/src/components/profile/subscription/UserSubscription.js b/src/components/profile/subscription/UserSubscription.js
index 3b29952..b0d734e 100644
--- a/src/components/profile/subscription/UserSubscription.js
+++ b/src/components/profile/subscription/UserSubscription.js
@@ -17,6 +17,7 @@ import Nip05Form from '@/components/profile/subscription/Nip05Form';
 import LightningAddressForm from '@/components/profile/subscription/LightningAddressForm';
 import RenewSubscription from '@/components/profile/subscription/RenewSubscription';
 import { SelectButton } from 'primereact/selectbutton';
+import { SUBSCRIPTION_PERIODS, calculateExpirationDate } from '@/constants/subscriptionPeriods';
 
 const UserSubscription = () => {
   const { data: session, update } = useSession();
@@ -52,13 +53,18 @@ const UserSubscription = () => {
   useEffect(() => {
     if (user && user.role) {
       setSubscribed(user.role.subscribed);
-      const subscribedAt = new Date(user.role.lastPaymentAt);
       
-      // Calculate subscription end date based on type
-      const daysToAdd = user.role.subscriptionType === 'yearly' ? 365 : 31;
-      const subscribedUntil = new Date(subscribedAt.getTime() + daysToAdd * 24 * 60 * 60 * 1000);
+      if (user.role.lastPaymentAt) {
+        const subscribedAt = new Date(user.role.lastPaymentAt);
+        
+        // Use the common helper to calculate expiration date
+        const subscribedUntil = calculateExpirationDate(subscribedAt, user.role.subscriptionType || 'monthly');
+        
+        setSubscribedUntil(subscribedUntil);
+      } else {
+        setSubscribedUntil(null);
+      }
       
-      setSubscribedUntil(subscribedUntil);
       if (user.role.subscriptionExpiredAt) {
         const expiredAt = new Date(user.role.subscriptionExpiredAt);
         setSubscriptionExpiredAt(expiredAt);
@@ -243,7 +249,7 @@ const UserSubscription = () => {
                         <span className="font-semibold">Current Plan:</span> {user?.role?.subscriptionType || 'monthly'} subscription
                       </p>
                       <p className="text-gray-300">
-                        <span className="font-semibold">Renews on:</span> {subscribedUntil?.toLocaleDateString()}
+                        <span className="font-semibold">Renews on:</span> {subscribedUntil ? subscribedUntil.toLocaleDateString() : 'N/A'}
                       </p>
                     </div>
                     <div className="flex flex-col gap-4">
diff --git a/src/pages/about.js b/src/pages/about.js
index 2d66796..2bc1dd1 100644
--- a/src/pages/about.js
+++ b/src/pages/about.js
@@ -18,6 +18,7 @@ import RenewSubscription from '@/components/profile/subscription/RenewSubscripti
 import Nip05Form from '@/components/profile/subscription/Nip05Form';
 import LightningAddressForm from '@/components/profile/subscription/LightningAddressForm';
 import MoreInfo from '@/components/MoreInfo';
+import { SUBSCRIPTION_PERIODS } from '@/constants/subscriptionPeriods';
 
 const AboutPage = () => {
   const { data: session, update } = useSession();
@@ -117,7 +118,7 @@ const AboutPage = () => {
     if (user && user.role) {
       setSubscribed(user.role.subscribed);
       const subscribedAt = new Date(user.role.lastPaymentAt);
-      const subscribedUntil = new Date(subscribedAt.getTime() + 31 * 24 * 60 * 60 * 1000);
+      const subscribedUntil = new Date(subscribedAt.getTime() + SUBSCRIPTION_PERIODS.MONTHLY.DAYS * 24 * 60 * 60 * 1000);
       setSubscribedUntil(subscribedUntil);
       if (user.role.subscriptionExpiredAt) {
         const expiredAt = new Date(user.role.subscriptionExpiredAt);