saulteafarmer/Stirling-PDF
1
0
Fork 0
mirror of https://github.com/Stirling-Tools/Stirling-PDF.git synced 2025-09-18 01:19:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove redudant constants

Browse Source
This commit is contained in:
Connor Yoh 2025-09-12 16:49:55 +01:00
parent 60b6316344
commit 18c71b259e
4 changed files with 6 additions and 34 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
frontend/src/components/tools/split/SplitSettings.tsx
View File

@ -1,6 +1,6 @@
import { Stack, TextInput, Select, Checkbox } from '@mantine/core';
import { useTranslation } from 'react-i18next';
import { isSplitMethod, SPLIT_METHODS, METHOD_TO_SPLIT_TYPE, SPLIT_TYPES } from '../../../constants/splitConstants';
import { isSplitMethod, SPLIT_METHODS } from '../../../constants/splitConstants';
import { SplitParameters } from '../../../hooks/tools/split/useSplitParameters';
export interface SplitSettingsProps {
@ -59,7 +59,7 @@ const SplitSettings = ({
const renderSplitValueForm = () => {
let label, placeholder;
switch (parameters.method) {
case SPLIT_METHODS.BY_SIZE:
label = t("split.value.fileSize.label", "File Size");
@ -135,8 +135,8 @@ const SplitSettings = ({
{/* Parameter Form */}
{parameters.method === SPLIT_METHODS.BY_PAGES && renderByPagesForm()}
{parameters.method === SPLIT_METHODS.BY_SECTIONS && renderBySectionsForm()}
{(parameters.method === SPLIT_METHODS.BY_SIZE ||
parameters.method === SPLIT_METHODS.BY_PAGE_COUNT ||
{(parameters.method === SPLIT_METHODS.BY_SIZE ||
parameters.method === SPLIT_METHODS.BY_PAGE_COUNT ||
parameters.method === SPLIT_METHODS.BY_DOC_COUNT) && renderSplitValueForm()}
{parameters.method === SPLIT_METHODS.BY_CHAPTERS && renderByChaptersForm()}
</Stack>

28
frontend/src/constants/splitConstants.ts
View File

@ -7,19 +7,6 @@ export const SPLIT_METHODS = {
BY_CHAPTERS: 'byChapters'
} as const;
// Legacy constants for backward compatibility
export const SPLIT_MODES = {
BY_PAGES: 'byPages',
BY_SECTIONS: 'bySections',
BY_SIZE_OR_COUNT: 'bySizeOrCount',
BY_CHAPTERS: 'byChapters'
} as const;
export const SPLIT_TYPES = {
SIZE: 'size',
PAGES: 'pages',
DOCS: 'docs'
} as const;
export const ENDPOINTS = {
[SPLIT_METHODS.BY_PAGES]: 'split-pages',
@ -30,24 +17,9 @@ export const ENDPOINTS = {
[SPLIT_METHODS.BY_CHAPTERS]: 'split-pdf-by-chapters'
} as const;
export const METHOD_TO_SPLIT_TYPE = {
[SPLIT_METHODS.BY_SIZE]: SPLIT_TYPES.SIZE,
[SPLIT_METHODS.BY_PAGE_COUNT]: SPLIT_TYPES.PAGES,
[SPLIT_METHODS.BY_DOC_COUNT]: SPLIT_TYPES.DOCS
} as const;
export type SplitMethod = typeof SPLIT_METHODS[keyof typeof SPLIT_METHODS];
export type SplitMode = typeof SPLIT_MODES[keyof typeof SPLIT_MODES];
export type SplitType = typeof SPLIT_TYPES[keyof typeof SPLIT_TYPES];
export const isSplitMethod = (value: string | null): value is SplitMethod => {
return Object.values(SPLIT_METHODS).includes(value as SplitMethod);
}
export const isSplitMode = (value: string | null): value is SplitMode => {
return Object.values(SPLIT_MODES).includes(value as SplitMode);
}
export const isSplitType = (value: string | null): value is SplitType => {
return Object.values(SPLIT_TYPES).includes(value as SplitType);
}

2
frontend/src/hooks/tools/split/useSplitOperation.ts
View File

@ -3,7 +3,7 @@ import { useTranslation } from 'react-i18next';
import { ToolType, useToolOperation, ToolOperationConfig } from '../shared/useToolOperation';
import { createStandardErrorHandler } from '../../../utils/toolErrorHandler';
import { SplitParameters, defaultParameters } from './useSplitParameters';
import { SPLIT_METHODS, METHOD_TO_SPLIT_TYPE } from '../../../constants/splitConstants';
import { SPLIT_METHODS } from '../../../constants/splitConstants';
import { useToolResources } from '../shared/useToolResources';
// Static functions that can be used by both the hook and automation executor

2
frontend/src/hooks/tools/split/useSplitParameters.ts
View File

@ -1,4 +1,4 @@
import { SPLIT_METHODS, SPLIT_MODES, SPLIT_TYPES, ENDPOINTS, METHOD_TO_SPLIT_TYPE, type SplitMethod, SplitMode, SplitType } from '../../../constants/splitConstants';
import { SPLIT_METHODS, ENDPOINTS, type SplitMethod } from '../../../constants/splitConstants';
import { BaseParameters } from '../../../types/parameters';
import { useBaseParameters, BaseParametersHook } from '../shared/useBaseParameters';